fix(caddy): TLS certificates trust on all platforms #34
Conversation
There was a problem hiding this comment.
praise: @lucasmirloup This is a great simplification. I think, I might have gone another way with the certificate storage (keep a volume, instead of writing a file to the system) but maybe this can be improved later by using a symlink to the volume instead of a copy
This approach will help caddy to renew its certificate without human intervention in the future.
| # Copy the certificate to a stable location (to simplify mounting on all Docker platforms) | ||
| sudo docker compose cp proxy:/data/caddy/pki/authorities/local/root.crt /etc/ssl/certs/Caddy.crt 2>/dev/null |
There was a problem hiding this comment.
nitpick (non-blocking): You should not write in a system directory without checking there is not already a file called Caddy.crt. You might rename this file with something more obvious like lephare-local.crt.
|
|
||
| rm /tmp/caddy | ||
| /tmp/caddy trust |
There was a problem hiding this comment.
question: Why removing the untrust before trusting a new one. It's was here to cleanup intermediary certificates ?
https://www.wrike.com/open.htm?id=1494735894