Skip to content

Commit

Permalink
Don't allow the user to snipe indicator handles
Browse files Browse the repository at this point in the history
Prior to these changes, the user could grab the ShowDragHandle while the
PanelMenu was hiding. This caused strange behavior.

Fixes ubports/ubuntu-touch#1257
  • Loading branch information
UniversalSuperBox committed Oct 14, 2019
1 parent 4fa0ad9 commit 2c2664a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions qml/Panel/PanelMenu.qml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ Showable {
width: root.barWidth + root.menuContentX // show handle should only cover panel items.
height: minimizedPanelHeight
direction: Direction.Downwards
enabled: !root.shown && root.available
enabled: !root.shown && root.available && !hideAnimation.running && !showAnimation.running
autoCompleteDragThreshold: maxTotalDragDistance / 2
stretch: true

Expand Down Expand Up @@ -268,7 +268,7 @@ Showable {
objectName: "hideDragHandle"
anchors.fill: handle
direction: Direction.Upwards
enabled: root.shown && root.available
enabled: root.shown && root.available && !hideAnimation.running && !showAnimation.running
hintDisplacement: units.gu(3)
autoCompleteDragThreshold: maxTotalDragDistance / 6
stretch: true
Expand Down

0 comments on commit 2c2664a

Please sign in to comment.