Mark all classes as readonly
#1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
reviewed
Dec 4, 2024
lcobucci
reviewed
Dec 4, 2024
| @@ -15,7 +15,7 @@ | |||
| * Serves like a small DI container to simplify the creation and usage | |||
| * of the objects. | |||
| */ | |||
| final class Configuration | |||
| final readonly class Configuration | |||
There was a problem hiding this comment.
We need to open a discussion about this component... its design is a bit too convoluted for me.
I'll post something soon...
lcobucci
reviewed
Dec 4, 2024
Comment on lines
+34
to
37
| public static function new(Encoder $encoder, ClaimsFormatter $claimFormatter): self | ||
| { | ||
| return new self($encoder, $claimFormatter); | ||
| } |
There was a problem hiding this comment.
This is something that we'll need to coordinate in v5.5 the migration path for...
There was a problem hiding this comment.
Migration API added in #1092
lcobucci
approved these changes
Dec 4, 2024
This concern is easy to address with new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1086
This PR needs a new
6.0.xbranch