Cmake: Set default build type to release #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obviates compiler warnings
|
In the past you've expressed a preference for making changes directly on your PRs, so I added d68c6dd to obviate the compiler warnings on the CI's Fedora target. I think it makes sense for LCM to configure a release build by default. I believe most people tend to use it as a tool rather than debug it. But since a default release build might be unexpected for a lot of users, I also added da0d7f9 to document this behavior as well as give instructions for users to override it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build instructions simply say
cmake ..so I kinda assumed this was already in place.