lcmgen: Emit comments for java and python #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosracd
approved these changes
Mar 31, 2024
| emit_continue("[]"); | ||
| emit_end(";"); | ||
| emit_end(";\n"); |
There was a problem hiding this comment.
This change does add an unnecessary newline in between the constructor and the last member, but I can't think of a good alternative. It could be removed from here and emit(0, ""); could be added on L124 before the emit(indent, "/**"); in emit_member_comment, but then that just adds an unnecessary extra newline in between the class line and its members.
I'm inclined to just merge as-is since this PR adds a lot of value; we can always open a follow-on PR if we want to change it and can think of a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.