python: EventLog accept pathlib.Path

[judfs]

pathlib was introduced in 3.4 (2014). Could also add the type hint typing.Union[str, bytes, os.PathLike]. PathLike is from py 3.6 (2016)

[nosracd]

Would it be possible to wrap these in try/except blocks? Then users on newer versions of Python could benefit from these features but users on older versions wouldn't be forced to upgrade to use LCM

[judfs]

I've found that if sys.version_info >= (3, 6): is preferred by pylance over try:.

What is the target supported versions? Do you want 3.3 to still work?

[nosracd]

I've found that if sys.version_info >= (3, 6): is preferred by pylance over try:.

I agree; that's a better way to do it

What is the target supported versions? Do you want 3.3 to still work?

That's a bit tricky. In the last release we dropped Python 2 support but we haven't declared a minimum version of Python 3. So right now it's just "as old as is reasonably convenient to support".

[judfs]

I assume this works, but I've not tested with older versions

[nosracd]

I tested this on Python 3.5 (Ubuntu 16.04) and it worked as expected (although I had to revert 9e827af to get cmake to find python). I tried to test it on Python 3.4 (Ubuntu 14.04), but that version of Ubuntu's cmake is too low of a version. In hindsight after exploring all that I think it makes to say that the minimum version we support is Python 3.6 (Ubuntu 18.04). I think the PR in its current state has some value because it makes the path easier for someone trying to get Python 3.5 to work with LCM (only need to revert one commit rather than two) so I'm good with merging it in its current state. I'm also good with merging just your original commit (6b59eb0) without the backwards compatibility. Which would you rather do?

[judfs]

I'm fine with as it is. It doesn't add much value but first commit doesn't have the type hint.

Readme should probably spell out Python >= 3.6 is supported. Somewhere it might be nice to enumerate everything LCM 1.4 supported as well.