Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Removed relref which is no longer in use. #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ringods
Copy link

@ringods ringods commented Feb 1, 2024

@jaxxstorm the relref fixer is no longer active in pulumi/registry. As a result, this would break the link:

https://github.com/pulumi/registry/pull/3884/files

Can you create a new patch release?


Ellipsis 🚀 This PR description was created by Ellipsis for commit 84a5b3f.

Summary:

This PR removes the inactive relref shortcode from a markdown link in /docs/installation-configuration.md, preventing the link from breaking.

Key points:

  • Removed relref shortcode from a markdown link in /docs/installation-configuration.md

Generated with ❤️ by ellipsis.dev

Removed `relref` which is no longer in use.
Copy link

github-actions bot commented Feb 1, 2024

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Reviewed entire PR up to commit 84a5b3f

Reviewed 11 lines of code across 1 files in 15 second(s).

See details
  • Skipped files: 0
  • Confidence threshold: 50%
  • Drafted 1 additional comments.
  • Workflow ID: wflow_yKBVuDmApj5GAiWE
View 1 draft comments

These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml.

Drafted 1 comments under confidence threshold

Filtered comment at docs/installation-configuration.md:65

Notes: The PR author has removed the relref shortcode from the link and replaced it with a relative URL. This change seems to be in line with the PR description, which states that relref is no longer in use. However, it's important to ensure that the new link works as expected. I'll check the codebase to see if the target of the link exists.

Please ensure that the link /registry/packages/vantage/api-docs/provider is valid and accessible. If the page does not exist, the link will lead to a 404 error page, which could confuse users.

Confidence changes required: 50%


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant