Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud-instances): enable IPv6 forwarding on eth0 for AWS and Azure #124

Merged
merged 2 commits into from
May 30, 2024

Conversation

jaxxstorm
Copy link
Member

@jaxxstorm jaxxstorm commented May 29, 2024

🚀 This description was created by Ellipsis for commit fa7022b

Summary:

This PR updates IPv6 forwarding to all interfaces and modifies userdata.tmpl files for AWS and Azure instances.

Key points:

  • Enable IPv6 forwarding on all interfaces for both AWS and Azure instances.
  • Update userdata.tmpl files for AWS and Azure to include the new sysctl command.
  • Applied in /provider/pkg/provider/aws/userdata.tmpl and /provider/pkg/provider/azure/userdata.tmpl.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot changed the title ... feat(cloud-instances): enable IPv6 forwarding on eth0 for AWS and Azure May 29, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to cb86ec0 in 1 minute and 22 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. provider/pkg/provider/aws/userdata.tmpl:11
  • Draft comment:
    The command sudo sysctl -w net.ipv6.conf.eth0.forwarding=1 assumes the presence of the eth0 interface. This might not be the case, especially in environments with different interface names or configurations. Consider verifying the interface name dynamically or ensuring that eth0 is the correct interface for IPv6 forwarding.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_vsLd6pAaseqLfcQJ


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

provider/pkg/provider/azure/userdata.tmpl Outdated Show resolved Hide resolved
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on fa7022b in 1 minute and 38 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_v7nwMBWa0a9BsTZ0


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

provider/pkg/provider/aws/userdata.tmpl Show resolved Hide resolved
@jaxxstorm jaxxstorm merged commit c8ee9e0 into main May 30, 2024
11 checks passed
@jaxxstorm jaxxstorm deleted the ipv6_forwarding branch May 30, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant