Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IP-routing): Enable IP forwarding and support multiple routes #123

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

jaxxstorm
Copy link
Member

@jaxxstorm jaxxstorm commented Apr 12, 2024

  • fix user data and tags in azure
  • fix outputs and edd public property
  • Switch to routes instead of route
  • enable ip forwarding

Ellipsis 🚀 This PR description was created by Ellipsis for commit 26b9982.

Summary:

This PR enables IP forwarding and updates the handling of routes to support multiple routes instead of a single one.

Key points:

  • Enabled IP forwarding in userdata.tmpl
  • Changed from single route to multiple routes in schema.yaml
  • Updated Bastion.cs, bastion.go, bastion.ts, and bastion.py to handle multiple routes

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot changed the title ... feat(IP-routing): Enable IP forwarding and support multiple routes Apr 12, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 26b9982
  • Looked at 238 lines of code in 6 files
  • Took 2 minutes and 13 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. sdk/go/bastion/azure/bastion.go:38:
  • Assessed confidence : 80%
  • Grade: 40%
  • Comment:
    Consider adding a validation to check if the 'routes' array is not empty. An empty array for routes might not make sense and could lead to unexpected behavior.
  • Reasoning:
    The PR author has changed the 'route' property to 'routes' and updated its type from string to array of strings in all the SDKs and schema. This change is consistent across all the files and seems to be correctly implemented. However, there is no validation to check if the array is empty. An empty array for routes might not make sense and could lead to unexpected behavior.

Workflow ID: wflow_EWDKwSku4YT4guAm


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@jaxxstorm jaxxstorm merged commit 6826de7 into main Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant