fix(bastion, userdata): adjust TailscaleTags retrieval and update tailscale up command

[jaxxstorm]

	🚀 This PR description was created by Ellipsis for commit 6c0deae.

Summary:

This PR adjusts the argument index for TailscaleTags retrieval in bastion.go and updates the tailscale up command in userdata.tmpl to include --authkey and --accept-dns=false options.

Key points:

• Modified bastion.go to adjust the argument index in strings.Join function for correct TailscaleTags retrieval.
• Updated userdata.tmpl to include --authkey and --accept-dns=false options in tailscale up command.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me!

• Reviewed the entire pull request up to 6c0deae
• Looked at 27 lines of code in 2 files
• Took 1 minute and 51 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.

1. provider/pkg/provider/azure/bastion.go:91:

• Assessed confidence : 0%
• Comment:
  The change in the index from 3 to 2 seems to be correct as the TailscaleTags are indeed the third argument in the pulumi.All function call, and arrays in Go are 0-indexed.
• Reasoning:
  The change in the bastion.go file is changing the index of the args array from 3 to 2 when joining the TailscaleTags into a CSV string. This change seems to be correct as the TailscaleTags are indeed the third argument in the pulumi.All function call, and arrays in Go are 0-indexed. Therefore, no issues are found in this change.

In the userdata.tmpl file, the change is adding the --accept-dns=false flag to the tailscale up command. This seems to be a new feature that the author is adding, and it doesn't seem to introduce any bugs. However, it's worth noting that this change will affect all instances where this template is used, and the author should make sure this is the desired behavior.

Overall, the changes in this PR seem to be correct and don't introduce any bugs.

2. provider/pkg/provider/azure/userdata.tmpl:16:

• Assessed confidence : 0%
• Comment:
  The addition of the --accept-dns=false flag to the tailscale up command seems to be a new feature. This change will affect all instances where this template is used, so please ensure this is the desired behavior.
• Reasoning:
  The change in the userdata.tmpl file is adding the --accept-dns=false flag to the tailscale up command. This seems to be a new feature that the author is adding, and it doesn't seem to introduce any bugs. However, it's worth noting that this change will affect all instances where this template is used, and the author should make sure this is the desired behavior.

Workflow ID: wflow_E2VSelH9IpQESoZX

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.