Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't package extra files #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pusewicz
Copy link

These extra files should be excluded from the gem when packaging as they cannot be used and take extra space unnecessary.

Diff

1,6c1
< [".github/FUNDING.yml",
<  ".github/workflows/CI.yml",
<  ".gitignore",
<  ".rubocop.yml",
<  ".ruby-version",
<  "CHANGELOG.md",
---
> ["CHANGELOG.md",
8,9d2
<  "Gemfile",
<  "Gemfile.lock",
12d4
<  "Rakefile",

Before

[".github/FUNDING.yml",
 ".github/workflows/CI.yml",
 ".gitignore",
 ".rubocop.yml",
 ".ruby-version",
 "CHANGELOG.md",
 "CODE_OF_CONDUCT.md",
 "Gemfile",
 "Gemfile.lock",
 "LICENSE.txt",
 "README.md",
 "Rakefile",
 "authentication-zero.gemspec",
 "lib/authentication-zero.rb",
 "lib/authentication_zero.rb",
 "lib/authentication_zero/version.rb",
 "lib/generators/authentication/USAGE",
 "lib/generators/authentication/authentication_generator.rb",
 "lib/generators/authentication/templates/config/initializers/omniauth.rb",
 "lib/generators/authentication/templates/config/initializers/webauthn.rb",
 "lib/generators/authentication/templates/config/redis/shared.yml",
 "lib/generators/authentication/templates/controllers/api/application_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/authentications/events_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/email_verifications_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/emails_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/password_resets_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/passwords_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/registrations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/sessions_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/application_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/authentications/events_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/home_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/email_verifications_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/emails_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/password_resets_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/invitations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/masquerades_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/passwords_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/registrations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/omniauth_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/passwordlesses_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/sudos_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/recovery_codes_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/security_keys_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/totps_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/recovery_codes_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/security_keys_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/totps_controller.rb.tt",
 "lib/generators/authentication/templates/erb/authentications/events/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/home/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/emails/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/password_resets/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/password_resets/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/invitations/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/passwords/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/registrations/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/passwordlesses/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/sudos/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/recovery_codes/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/security_keys/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/totps/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/recovery_codes/_recovery_code.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/recovery_codes/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_form_confirm.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_form_edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_security_key.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/totps/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/email_verification.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/invitation_instructions.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/password_reset.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/passwordless.html.erb.tt",
 "lib/generators/authentication/templates/javascript/controllers/application.js",
 "lib/generators/authentication/templates/lib/account_middleware.rb",
 "lib/generators/authentication/templates/mailers/user_mailer.rb.tt",
 "lib/generators/authentication/templates/migrations/create_accounts_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_events_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_recovery_codes_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_security_keys_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_sessions_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_sign_in_tokens_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_users_migration.rb.tt",
 "lib/generators/authentication/templates/models/account.rb.tt",
 "lib/generators/authentication/templates/models/concerns/account_scoped.rb",
 "lib/generators/authentication/templates/models/current.rb.tt",
 "lib/generators/authentication/templates/models/event.rb.tt",
 "lib/generators/authentication/templates/models/recovery_code.rb.tt",
 "lib/generators/authentication/templates/models/security_key.rb.tt",
 "lib/generators/authentication/templates/models/session.rb.tt",
 "lib/generators/authentication/templates/models/sign_in_token.rb.tt",
 "lib/generators/authentication/templates/models/user.rb.tt",
 "lib/generators/authentication/templates/test_unit/application_system_test_case.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/email_verifications_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/emails_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/password_resets_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/passwords_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/registrations_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/sessions_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/email_verifications_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/emails_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/password_resets_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/passwords_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/registrations_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/sessions_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/mailers/user_mailer_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/identity/emails_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/identity/password_resets_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/passwords_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/registrations_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/sessions_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/test_helper.rb.tt",
 "lib/generators/authentication/templates/test_unit/users.yml"]

After

["CHANGELOG.md",
 "CODE_OF_CONDUCT.md",
 "LICENSE.txt",
 "README.md",
 "authentication-zero.gemspec",
 "lib/authentication-zero.rb",
 "lib/authentication_zero.rb",
 "lib/authentication_zero/version.rb",
 "lib/generators/authentication/USAGE",
 "lib/generators/authentication/authentication_generator.rb",
 "lib/generators/authentication/templates/config/initializers/omniauth.rb",
 "lib/generators/authentication/templates/config/initializers/webauthn.rb",
 "lib/generators/authentication/templates/config/redis/shared.yml",
 "lib/generators/authentication/templates/controllers/api/application_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/authentications/events_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/email_verifications_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/emails_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/identity/password_resets_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/passwords_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/registrations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/api/sessions_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/application_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/authentications/events_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/home_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/email_verifications_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/emails_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/identity/password_resets_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/invitations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/masquerades_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/passwords_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/registrations_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/omniauth_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/passwordlesses_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions/sudos_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/sessions_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/recovery_codes_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/security_keys_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/challenge/totps_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/recovery_codes_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/security_keys_controller.rb.tt",
 "lib/generators/authentication/templates/controllers/html/two_factor_authentication/profile/totps_controller.rb.tt",
 "lib/generators/authentication/templates/erb/authentications/events/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/home/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/emails/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/password_resets/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/identity/password_resets/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/invitations/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/passwords/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/registrations/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/passwordlesses/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/sessions/sudos/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/recovery_codes/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/security_keys/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/challenge/totps/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/recovery_codes/_recovery_code.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/recovery_codes/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_form_confirm.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_form_edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/_security_key.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/edit.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/index.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/security_keys/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/two_factor_authentication/profile/totps/new.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/email_verification.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/invitation_instructions.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/password_reset.html.erb.tt",
 "lib/generators/authentication/templates/erb/user_mailer/passwordless.html.erb.tt",
 "lib/generators/authentication/templates/javascript/controllers/application.js",
 "lib/generators/authentication/templates/lib/account_middleware.rb",
 "lib/generators/authentication/templates/mailers/user_mailer.rb.tt",
 "lib/generators/authentication/templates/migrations/create_accounts_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_events_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_recovery_codes_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_security_keys_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_sessions_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_sign_in_tokens_migration.rb.tt",
 "lib/generators/authentication/templates/migrations/create_users_migration.rb.tt",
 "lib/generators/authentication/templates/models/account.rb.tt",
 "lib/generators/authentication/templates/models/concerns/account_scoped.rb",
 "lib/generators/authentication/templates/models/current.rb.tt",
 "lib/generators/authentication/templates/models/event.rb.tt",
 "lib/generators/authentication/templates/models/recovery_code.rb.tt",
 "lib/generators/authentication/templates/models/security_key.rb.tt",
 "lib/generators/authentication/templates/models/session.rb.tt",
 "lib/generators/authentication/templates/models/sign_in_token.rb.tt",
 "lib/generators/authentication/templates/models/user.rb.tt",
 "lib/generators/authentication/templates/test_unit/application_system_test_case.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/email_verifications_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/emails_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/identity/password_resets_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/passwords_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/registrations_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/api/sessions_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/email_verifications_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/emails_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/identity/password_resets_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/passwords_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/registrations_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/controllers/html/sessions_controller_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/mailers/user_mailer_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/identity/emails_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/identity/password_resets_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/passwords_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/registrations_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/system/sessions_test.rb.tt",
 "lib/generators/authentication/templates/test_unit/test_helper.rb.tt",
 "lib/generators/authentication/templates/test_unit/users.yml"]

These extra files should be excluded from the gem when packaging as they cannot be used and take extra space unnecessary.
@pusewicz
Copy link
Author

pusewicz commented Jun 7, 2024

@lazaronixon Would it be possible to close this PR?

@Faq
Copy link

Faq commented Jun 17, 2024

Those files are needed.

@pusewicz
Copy link
Author

@Faq What are they needed for in a packaged gem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants