Optionally generate RSpec specs instead of Test::Unit tests #88
+315
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up the configuration from the parent application, so RSpec should be installed and configured before running the generator.
|
ref. #67 |
johnhailu
reviewed
Dec 23, 2023
|
|
||
| describe "GET #show" do | ||
| it "returns HTTP success" do | ||
| get session_url(user.sessions.last), headers: default_headers |
There was a problem hiding this comment.
Here user.sessions will allways be blank. since we are using let, it will be available only when we access token or default_header which is not the case here.
|
I also very interested to have rspec tests. This would be a great improvement. |
I haven't had any more time to work on this recently, but I'm more than happy to accept contributions to help me get this over the line. We're working against a moving target right now because new features and new Test::Unit tests get added all the time 😀 |
|
Hey @stevehill1981 I would love to help on the RSpec tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up the configuration from the parent application, so RSpec should be installed and configured before running the generator.
Very much WIP, a lot of work to be done before this is ready.