feat(slider): 增加小数滑块 #1794
Closed
feat(slider): 增加小数滑块 #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Diyar-IT 后续 PR 标题及 Commit message 按照统一格式规范书写，可大致遵循 Angular 团队的 Commit 规范即可。
如：feat(slider): 增加小数滑块 |
Sight-wcg
requested changes
Apr 17, 2024
| @@ -113,11 +113,15 @@ layui.define(['jquery', 'lay'], function(exports){ | |||
| //间隔值不能小于等于 0 | |||
| if(options.step <= 0) options.step = 1; | |||
|
|
|||
| if (options.min < 0 && options.step >= 1) options.step = 0.01; | |||
| @@ -319,7 +386,26 @@ layui.define(['jquery', 'lay'], function(exports){ | |||
| if(options.type === 'vertical'){ | |||
There was a problem hiding this comment.
当设置 type: 'vertical' 时，效果和 type: 'default' 不一致
| var scale = (options.value - options.min) / (options.max - options.min) * 100 + '%'; | ||
| scale = (options.value - options.min) / (options.max - options.min) * 100; | ||
|
|
||
| if (options.min < 0) { |
There was a problem hiding this comment.
range: true 时应该不需要处理滑块偏移
| style.push('height:' + scale); | ||
| style.push('bottom:' + (scaleFir || 0)); | ||
| } else { | ||
| if (options.min < 0) { |
There was a problem hiding this comment.
range: true 时应该不需要处理滑块偏移
| @@ -319,7 +386,26 @@ layui.define(['jquery', 'lay'], function(exports){ | |||
| if(options.type === 'vertical'){ | |||
| sliderAct.find('.' + SLIDER_BAR).css({"height":wrapWidth + '%', "bottom":minLeft + '%'}); | |||
| }else{ | |||
| sliderAct.find('.' + SLIDER_BAR).css({"width":wrapWidth + '%', "left":minLeft + '%'}); | |||
| if (options.min < 0) { | |||
There was a problem hiding this comment.
range: true 时应该不需要处理滑块偏移
|
|
由于该 PR 超过一个月未按照要求更改，先做关闭。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😃 本次 PR 的变化性质
🌱 本次 PR 的变化内容
效果：
https://stackblitz.com/edit/stackblitz-starters-mcyldd?file=index.html
✅ 本次 PR 的满足条件