-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy button added #5524
base: master
Are you sure you want to change the base?
copy button added #5524
Conversation
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit d3e9ae5 at: https://66386ba8f6a8fe76cda63d22--layer5.netlify.app |
Adding as an agenda item for websites call. |
@Rexford74 Should we use a copy icon in place of |
Those are fine suggestions @lakshz and I think they can actually fly. |
@Rexford74 Got it. The "Show code" section needs more features, in addition to the Copy button.
|
@lakshz I think 3 buttons are not Nedded ! |
@narasimha-1511 Let's stick to adding a copy button in this PR. We can re-iterate on the other features (if they are needed) moving forward. I've left some comments, for you to solve. |
Signed-off-by: Narasimha <[email protected]>
Hey @narasimha-1511 , let's discuss this on today's website meeting at 12:00 pm GMT / 5:30 PM IST. I am adding this as an agenda item. Please join if you are available during the meet. |
Signed-off-by: Narasimha <[email protected]>
Signed-off-by: Narasimha <[email protected]>
All changes done as requested
🚀 Preview for commit 9b66ec2 at: https://6641c7241107b276d1a0c159--layer5.netlify.app |
Signed-off-by: Narasimha <[email protected]>
importing the color into the svg
🚀 Preview for commit 775d278 at: https://664ee88be3d958cbacaf54f7--layer5.netlify.app |
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 3ae961e at: https://664ef04482a7a5c1e72c673b--layer5.netlify.app |
@narasimha-1511 whats the status here, will you share your progress in upcoming website meet? |
Yeah for sure @sudhanshutech |
@narasimha-1511 what is that status? |
@leecalcote Almost Done , Need a Review |
Recording.2024-05-30.155053.mp4 |
@lakshz we're ready for a final round of review here. |
@narasimha-1511 Instead of showing a toast on copying the code, replace the copy icon with a |
@lakshz Sure ! , i will make the following changes |
Description
This PR fixes #5517
Notes for Reviewers
Signed commits