-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new plugin system using PF4J #1111
Open
DRSchlaubi
wants to merge
19
commits into
lavalink-devs:master
Choose a base branch
from
DRSchlaubi:feature/new-plugin-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement new plugin system using PF4J #1111
DRSchlaubi
wants to merge
19
commits into
lavalink-devs:master
from
DRSchlaubi:feature/new-plugin-system
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoxin
reviewed
Nov 10, 2024
LavalinkServer/src/main/java/lavalink/server/bootstrap/PluginCompomentClassLoader.kt
Outdated
Show resolved
Hide resolved
devoxin
reviewed
Nov 10, 2024
LavalinkServer/src/main/java/lavalink/server/bootstrap/PluginCompomentClassLoader.kt
Outdated
Show resolved
Hide resolved
…ompomentClassLoader.kt Co-authored-by: devoxin <[email protected]>
Lets hope this gets merged soon: pf4j/pf4j#595 |
A new branch for the gradle plugin has been created. |
DRSchlaubi
changed the title
Implement new plugin systm using PF4J
Implement new plugin system using PF4J
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1110
!!! BREAKING CHANGES
Note
Old plugins will continue to work, however it is advised to update to the new system as legacy support should be removed eventually
Spring components with dependencies have to be annotated with @extension
Due to the nature of Bean installation in the new plugin system you might need to tell Lavalink to load certain components first
Example