Restructured compiler logic #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
csansoon
changed the base branch from
canary
to
fix/compiler-can-run-methods-from-scoped-variables-canary
4 tasks
csansoon
force-pushed
the
fix/compiler-can-run-methods-from-scoped-variables-canary
branch
from
b2fee7f
to
d33e41c
Compare
csansoon
changed the base branch from
fix/compiler-can-run-methods-from-scoped-variables-canary
to
canary
csansoon
force-pushed
the
restructured-compiler-logic
branch
2 times, most recently
from
c8a9d19
to
2eb5531
Compare
| @@ -537,7 +537,7 @@ describe('custom methods', async () => { | |||
| }) | |||
| const error = await getExpectedError(action, CompileError) | |||
| expect(error.code).toBe('function-call-error') | |||
| expect(error.message).toBe("Error calling function 'fooFn': \nError bar") | |||
There was a problem hiding this comment.
Yes! The error message is a bit more generic now, but it will still showing the reference to the exact part of the query where it's the failing function when running latitude run for debugging purposes.
csansoon
force-pushed
the
restructured-compiler-logic
branch
2 times, most recently
from
cd48840
to
f155f00
Compare
csansoon
force-pushed
the
restructured-compiler-logic
branch
from
f155f00
to
0931006
Compare
andresgutgon
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Moved all of the logic for resolving 'logic nodes' from the main compiler/index.ts file, to different files for better organization. This change is made because this main file was getting way too long and complicated.
This new structure works like this:
Each Logic Node has its own file with a
resolvemethod that defines how to resolve the value returned by this method. Then, there's aresolveLogicNodemethod that runs the correctresolvefunction based on the node type.🚂 TRENECITO. This PR was needed so that the next PR is not 2000 LOC :)
🚉 Next station: #434