Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new csv type of report - per-task #101

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

fighterpoul
Copy link
Contributor

This PR adds new CSV type of report - per-task - which displays a CSV document where each task has its details displayed in a row.

Details:

  • new csv-section: per-task or per_task
  • move timedelta_to_billable to report.common, as it is no longer used only by per_day report
  • integration test

@larose
Copy link
Owner

larose commented Jan 12, 2024

Thanks for this PR! The CI jobs failed because it was trying to use ubuntu-18.04 which is no longer supported by GitHub. I've updated it to ubuntu-22.04 in #102, but I also had to update all python dependencies because some of them were old and weren't compatible with python 3.8+.

Could you rebase your PR on master?

I'll aim to review your PR within the upcoming week.

@fighterpoul
Copy link
Contributor Author

@larose done. Indeed I have started implementing this by using Python 3.10 but it was not working well as far as development is concerned. Great to get it updated :)

Copy link
Owner

@larose larose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left one comment but otherwise it looks good to me!

print(" -- No activities for this time range --", file=output)
return

fieldnames = ["task", "project", "date", "duration", "type", "comment"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In

fieldnames = ["date", "hours", "duration", "projects", "tasks"]
the usage of the plural form is applied to hours, projects and tasks. We should be consistent. Either we change to plural here or change to singular in per_day/csv_view.py.

Also, let's arrange the columns in a more logical order, moving from general to specific. For instance, let's reorder the first three columns to be "date" "project" and "task" in that sequence.

@larose larose merged commit 85fdd02 into larose:master Jan 18, 2024
5 checks passed
@larose
Copy link
Owner

larose commented Jan 18, 2024

Thanks! Feel free to open a PR to put your real name here if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants