Fix rebound on mac #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This should fix the linking issues on mac. Essentially we don't try in cmake, and instead just run
install_name_toolafter the build completes to set the@rpathin the binary directly. Because of this change, we also no longer need to movelibrebound.soafter building it, so I got rid of that step too.With this, I can now successfully execute artemis from anywhere and move the binary anywhere and execute it.
I also added the
-Wno-deprecated-declarationsto suppress the warnings from singularity.Description of Changes
Checklist