-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(scores): remove fk constraint from traceId and observationId on scores, change to projectId #2012
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* chore(scores): drop fk on traces and observations * trpc update * push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review, looks good to me
fixed api auth, should allow access to scores with |
...ations/20240513082203_scores_unique_id_and_projectid_instead_of_id_and_traceid/migration.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge, will do later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxdeichmann I adapted the tests to the desired change of this PR. can you check and approve this change?
Dependency: #2014, both PRs should be merged at the same time.