Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update model_input_constants to add SambaNovaComponent #5368

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edwinjosechittilappilly
Copy link
Collaborator

Add sambanova to models in agents.

This pull request includes changes to integrate SambaNova as a new model component in the backend. The most important changes include importing the SambaNova component, defining a function to get SambaNova inputs and fields, and updating the model providers dictionary to include SambaNova.

Integration of SambaNova component:

add sambanova to models
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as draft December 19, 2024 18:20
@dosubot dosubot bot added the enhancement New feature or request label Dec 19, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #5368 will degrade performances by 61.01%

Comparing feat-add-sambanova-to-agents (5b53e61) with main (e657e9d)

Summary

❌ 3 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-add-sambanova-to-agents Change
test_get_and_cache_all_types_dict 1 ms 2.6 ms -61.01%
test_setup_llm_caching 1.2 ms 2.1 ms -43.3%
test_successful_run_with_input_type_text 258.4 ms 323.7 ms -20.2%

agent when toolcalling streaming is not available.
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant