Skip to content

Commit

Permalink
🔧 (dropdownComponent/index.tsx): refactor dropdownComponent to improv…
Browse files Browse the repository at this point in the history
…e code readability and remove unnecessary ShadTooltip component
  • Loading branch information
Cristhianzl authored and anovazzi1 committed Dec 30, 2024
1 parent 870aedf commit 8027f2c
Showing 1 changed file with 22 additions and 24 deletions.
46 changes: 22 additions & 24 deletions src/frontend/src/components/core/dropdownComponent/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,31 +131,29 @@ export default function Dropdown({
<CommandEmpty>No values found.</CommandEmpty>
<CommandGroup defaultChecked={false}>
{filteredOptions?.map((option, index) => (
<ShadTooltip key={index} delayDuration={700} content={option}>
<div>
<CommandItem
value={option}
onSelect={(currentValue) => {
onSelect(currentValue);
setOpen(false);
}}
className="items-center overflow-hidden truncate"
data-testid={`${option}-${index}-option`}
>
{customValue === option && (
<span className="text-muted-foreground">Text:&nbsp;</span>
<div>
<CommandItem
value={option}
onSelect={(currentValue) => {
onSelect(currentValue);
setOpen(false);
}}
className="items-center overflow-hidden truncate hover:cursor-pointer"
data-testid={`${option}-${index}-option`}
>
{customValue === option && (
<span className="text-muted-foreground">Text:&nbsp;</span>
)}
<span className="truncate">{option}</span>
<ForwardedIconComponent
name="Check"
className={cn(
"ml-auto h-4 w-4 shrink-0 text-primary",
value === option ? "opacity-100" : "opacity-0",
)}
<span className="truncate">{option}</span>
<ForwardedIconComponent
name="Check"
className={cn(
"ml-auto h-4 w-4 shrink-0 text-primary",
value === option ? "opacity-100" : "opacity-0",
)}
/>
</CommandItem>
</div>
</ShadTooltip>
/>
</CommandItem>
</div>
))}
</CommandGroup>
</CommandList>
Expand Down

0 comments on commit 8027f2c

Please sign in to comment.