Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]/chat_models/bedrock.py - added yield after callback of on_llm_new_token #28920

Conversation

meenakshiruia
Copy link

Thank you for contributing to LangChain!

- **Description:** Invoke callback for on_llm_new_token prior to yielding tokens for bedrock.py
- **Issue:** #16913 

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 25, 2024 6:40pm

@dosubot dosubot bot added community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Dec 25, 2024
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is already implemented in the langchain-aws version. You should be seeing warnings directing you to that version, away from the langchain-community version. There is a large gap in functionality between the two.

@ccurme ccurme closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants