Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add FalkorDB Chat Message History and Update Package Registry #28914

Merged

Conversation

kingtroga
Copy link
Contributor

This commit updates the documentation and package registry for the FalkorDB Chat Message History integration.

Changes:

  • Added a comprehensive example notebook falkordb_chat_message_history.ipynb demonstrating how to use FalkorDB for session-based chat message storage.

  • Added a provider notebook for FalkorDB

  • Updated libs/packages.yml to register FalkorDB as an integration package, following LangChain's new guidelines for community integrations.

Notes:

  • This update aligns with LangChain's process for registering new integrations via documentation updates and package registry modifications.

  • No functional or core package changes were made in this commit.

@kingtroga kingtroga requested a review from efriis as a code owner December 25, 2024 08:35
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:35pm

@dosubot dosubot bot added 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 25, 2024
@kingtroga kingtroga force-pushed the falkordbmessagehistorycreationnewnew branch from a2dc382 to 36bc8dc Compare December 25, 2024 08:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 25, 2024
@kingtroga kingtroga force-pushed the falkordbmessagehistorycreationnewnew branch from c22931a to f3d8c52 Compare December 27, 2024 09:42
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 27, 2024
@kingtroga
Copy link
Contributor Author

Hi @efriis,

I created a PR that includes only the requested changes to the docs and libs/package.yml files. However, Vercel keeps failing because the following lacked providers pages: exa, prompty, sema4, google-genai, google-vertexai, google-community, nvidia-ai-endpoints, postgres, azure-dynamic-sessions, and sqlserver.

I went ahead provided provider pages for them : ) , but Vercel still fails : (. So now I've reverted back to my initial FalkorDB-specific commit.

Pls, could you clarify what I need to adjust to move this forward?

@kingtroga
Copy link
Contributor Author

@efriis

1 similar comment
@kingtroga
Copy link
Contributor Author

@efriis

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 2, 2025
@kingtroga
Copy link
Contributor Author

Hi @efriis,

I created a PR that includes only the requested changes to the docs and libs/package.yml files. However, Vercel keeps failing because the following lacked providers pages: exa, prompty, sema4, google-genai, google-vertexai, google-community, nvidia-ai-endpoints, postgres, azure-dynamic-sessions, and sqlserver.

I went ahead provided provider pages for them : ) , but Vercel still fails : (. So now I've reverted back to my initial FalkorDB-specific commit.

Pls, could you clarify what I need to adjust to move this forward?

@ccurme ccurme self-assigned this Jan 2, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 2, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth updating the vector store page as well to point to the langchain-falkordb implementation instead of langchain-community.

Comment on lines +37 to +41
"```python\n",
"from langchain_community.vectorstores.falkordb_vector import FalkorDBVector\n",
"```\n",
"or \n",
"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should remove the community import. Otherwise readers could be confused about which implementation is recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to do that but I'm really scared of opening another PR that will take months to close again.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 2, 2025
@ccurme ccurme merged commit ba9dfd9 into langchain-ai:master Jan 2, 2025
13 checks passed
pprados pushed a commit to pprados/langchain that referenced this pull request Jan 3, 2025
…angchain-ai#28914)

This commit updates the documentation and package registry for the
FalkorDB Chat Message History integration.

**Changes:**

- Added a comprehensive example notebook
falkordb_chat_message_history.ipynb demonstrating how to use FalkorDB
for session-based chat message storage.

- Added a provider notebook for FalkorDB

- Updated libs/packages.yml to register FalkorDB as an integration
package, following LangChain's new guidelines for community
integrations.

**Notes:**

- This update aligns with LangChain's process for registering new
integrations via documentation updates and package registry
modifications.

- No functional or core package changes were made in this commit.

---------

Co-authored-by: Chester Curme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants