feat: support IVF_HNSW_PQ #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also simplifies the code of creating index with macro Signed-off-by: BubbleCal <[email protected]>
github-actions
bot
added
enhancement
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
westonpace
approved these changes
May 20, 2024
rust/lancedb/src/table.rs
Outdated
| if !Self::supported_vector_data_type(field.data_type()) { | ||
| return Err(Error::InvalidInput { | ||
| message: format!( | ||
| "An IVF HNSW SQ index cannot be created on the column `{}` which has data type {}", |
There was a problem hiding this comment.
Suggested change
| "An IVF HNSW SQ index cannot be created on the column `{}` which has data type {}", | |
| "An IVF HNSW PQ index cannot be created on the column `{}` which has data type {}", |
Comment on lines
+1281
to
+1286
| let num_partitions = if let Some(n) = index.num_partitions { | ||
| n | ||
| } else { | ||
| suggested_num_partitions(self.count_rows(None).await?) | ||
| }; | ||
| let num_sub_vectors: u32 = if let Some(n) = index.num_sub_vectors { |
There was a problem hiding this comment.
Minor nit: you could probably use unwrap_or_else here too...
let num_partitions = index.num_partitions.unwrap_or_else(|| suggested_num_partitions(self.count_rows(None).await?));
There was a problem hiding this comment.
this can't be done because await not available in the non-async closure
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also simplifies the code of creating index with macro