PHP 8.4 support added

[manishranjan-adobe]

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

[gsteel]

Thanks @manishranjan-adobe - There are a couple of BC breaks here that need reverting

[gsteel]

Please fix CS issues first

[manishranjan-adobe]

Please fix CS issues first

@gsteel I see, we are using an outdated version of laminas/laminas-coding-standard which ultimately relies on squizlabs/php_codesniffer again which is not supporting 8.0 onwards. I am not sure if it kept outdated for a reason.

[gsteel]

An upgrade to laminas-coding-standard 2.5 or 3.0 may be required, at which point the direct dev dependency on phpcs can be dropped

[manishranjan-adobe]

@gsteel I have fixed the PHPCS issues. Also, the laminas/laminas-coding-standard and squizlabs/php_codesniffer were updated.

You might need to fix the CI pipeline. The below check may not be working properly after the upgrade.
./vendor/bin/phpcs -q --report=checkstyle | cs2pr

[samsonasik]

You should can run:

vendor/bin/phpcbf

to fix cs

[manishranjan-adobe]

@gsteel @samsonasik All checks passed.

[gsteel]

A few more adjustments and we should be getting there!

[manishranjan-adobe]

@gsteel PR looks good to me. Let us know, if we miss something or need to relook. cheers

[gsteel]

@manishranjan-adobe Please address @samsonasik's review feedback and then this can get merged 👍

[manishranjan-adobe]

@samsonasik Suggested changes addressed. Please have a look. Thanks

[manishranjan-adobe]

@gsteel As suggested, the changes have been made. Thanks

[samsonasik]

LGTM 👍

[gsteel]

Thanks @manishranjan-adobe 😅