Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert copyright symbols to Unicode #924

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

DanRStevens
Copy link
Collaborator

Related: #922

I noticed my editor wanted to auto correct the copyright symbols to a Unicode encoding. It makes it frustrating to edit files that aren't already converted, as the change either adds noise to commits, or needs to be manually skipped when adding changes.

Would be nice to get confirmation from people using Windows that Unicode copyright symbols display correctly in Visual Studio.

@cugone
Copy link
Contributor

cugone commented Jul 15, 2021

Confirmed, they display correctly even if the project tells the compiler to Use Multi-byte Characterset.

@DanRStevens
Copy link
Collaborator Author

Thank you.

@DanRStevens DanRStevens merged commit 2ca9f5c into master Jul 15, 2021
@DanRStevens DanRStevens deleted the unicodeCopyrightSymbols branch July 15, 2021 03:41
@cugone
Copy link
Contributor

cugone commented Jul 15, 2021

I did notice that even though it displays correctly in visual studio, GitKraken does not and they show up as the questionmark glyph. It's probably a setting that I need to change somewhere.

@DanRStevens
Copy link
Collaborator Author

Do you mean the old encoding, or the new encoding?

https://superuser.com/questions/1405232/how-to-configure-gitkraken-to-iso-8859-1-encoding

For the time being Gitkraken supports only UTF-8

@cugone
Copy link
Contributor

cugone commented Jul 15, 2021

The new encoding shows up as the question mark in GitKraken file views. I found that question as well. The poster specifically said the problem appears as stashing/popping changes the encoding and another question on SO used hunk staging and they said that's that what caused it. I do not use hunk staging and instead use line-by-line, selected lines, or whole-file staging and simple tests did not reproduce the issue and the glyph correctly rendered in visual studio and did not change the glyph between saves, stages in and out, stashing/popping, and push/pulls; so, I wouldn't worry about it until it actually happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants