Fix missing extern warnings #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passed the flag `-Wmissing-variable-declarations`, Clang will warn about global variables that have no `extern` declaration. These should either have an extern declaration (for globals), or be wrapped in an anonymous namespace for file scoped variables.
|
Closing to rework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #528 (
-Wmissing-variable-declarations)Wraps file level variables in an anonymous namespace to limit their scope. This prevents warnings when Clang is passed the
-Wmissing-variable-declarationsflag.More long term, we'll probably want to move some of these into function level locals.