Ignore some files when running cppclean
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know it doesn't need to include anything, since it doesn't use anything. The warning misses the point. The header exists solely to easily import everything from NAS2D, hence it's supposed to include everything, even though it uses nothing.
We don't care about warnings in this file. It's external code, which we don't plan to maintain. If anything, there is a plan to remove it, and move to TinyXml2, added as an external dependency, rather than embedded in the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings about unused includes in
NAS2D.hare a bit silly, since the purpose of that file is to provide an easy include everything solution, and of course it doesn't use anything it includes.Similarly, there are some warnings about the TinyXML code that we don't intend to fix. It's external code, and it's due to be eventually replaced by TinyXML2. No need to expend effort on minor warnings in external code which is going to be removed.
Somewhat related to Issue #528