remote/client: fallback to telnet when microcom is not available #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microcom is generally not available on rpm based distributions[1], making it hard to setup labgrid client on them. [1] https://repology.org/project/microcom/versions Signed-off-by: Nick Cao <[email protected]>
|
See also this: I was going to take a look at implementing something internal...but if you have time/inclintation to do it, PLMK |
|
This workaround is not really invasive, so I'd be inclined to merge it. @Emantor @Bastian-Krause? |
sjg20
approved these changes
May 23, 2024
Emantor
previously approved these changes
May 28, 2024
|
Hi again, I implemented a simple internal terminal here: |
aparcar
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microcom is generally not available on rpm based distributions[1], making it hard to setup labgrid client on them.
[1] https://repology.org/project/microcom/versions
Description
Checklist
Tested the telnet code path in a fedora container.