Python 3.12 compatibility #1260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
========================================
- Coverage 63.1% 63.1% -0.1%
========================================
Files 160 160
Lines 11914 11914
========================================
- Hits 7520 7519 -1
- Misses 4394 4395 +1 ☔ View full report in Codecov by Sentry. |
Bastian-Krause
force-pushed
the
bst/python3.12
branch
from
e9924e5
to
9d68ed0
Compare
Bastian-Krause
force-pushed
the
bst/python3.12
branch
from
9d68ed0
to
234a20d
Compare
Bastian-Krause
force-pushed
the
bst/python3.12
branch
2 times, most recently
from
f36e042
to
810bafa
Compare
Bastian-Krause
force-pushed
the
bst/python3.12
branch
2 times, most recently
from
b81d4b2
to
0f3c2cd
Compare
Bastian-Krause
force-pushed
the
bst/python3.12
branch
from
0f3c2cd
to
12212de
Compare
eth-utils<2.3.0 required to circumvent the following error:
Traceback (most recent call last):
File "/home/runner/work/labgrid/labgrid/crossbar-venv/bin/crossbar", line 5, in <module>
from crossbar import run
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/crossbar/__init__.py", line 19, in <module>
import eth_abi
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/__init__.py", line 15, in <module>
from eth_abi.abi import ( # NOQA
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/abi.py", line 1, in <module>
from eth_abi.codec import (
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/codec.py", line 12, in <module>
from eth_abi.decoding import (
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/decoding.py", line 8, in <module>
from eth_utils import (
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/__init__.py", line 86, in <module>
from .network import (
File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/network.py", line 7, in <module>
from eth_typing import ChainId
ImportError: cannot import name 'ChainId' from 'eth_typing' (/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_typing/__init__.py)
Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/python3.12
branch
from
12212de
to
b4be952
Compare
1 task
sjg20
approved these changes
Apr 12, 2024
We will move to gRPC eventually (see #1417). |
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 8, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes labgrid-project#1260 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 8, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes labgrid-project#1260 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 13, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes labgrid-project#1260 Signed-off-by: Bastian Krause <[email protected]>
4 tasks
Bastian-Krause
added a commit
that referenced
this pull request
Aug 13, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes #1260 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
that referenced
this pull request
Aug 13, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes #1260 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 13, 2024
The latest crossbar release was not compatible with python3.12. Now that the crossbar dependency is gone, we can finally advertise python3.12 compatibility. Closes labgrid-project#1260 Signed-off-by: Bastian Krause <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.12 is expected to be released on 2023-10-02. Now that 3.12.0-rc1 is released and the ABI settled, it's a good time to see what needs fixing. It turns out, labgrid itself works fine, but some dependencies are not ready, yet:
ModuleNotFoundError: No module named 'asyncore')This draft PR works around these issues (by using pre-releases, switching from pypi to git URLs, switching to forks).
Checklist