Allow contract config to suggest relative's template #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
adamiak
changed the title
adamiak
changed the title
adamiak
changed the title
mateuszradomski
approved these changes
May 28, 2024
Comment on lines
+40
to
+56
| function getAddresses( | ||
| value: ContractValue | undefined, | ||
| template?: string, | ||
| ): EthereumAddress[] { | ||
| if (Array.isArray(value)) { | ||
| return value.flatMap((v) => getAddresses(v, template)) | ||
| } else if (typeof value === 'object') { | ||
| return Object.values(value).flatMap((v) => getAddresses(v, template)) | ||
| } else if (typeof value === 'string') { | ||
| try { | ||
| return [EthereumAddress(value)] | ||
| } catch { | ||
| return [] | ||
| } | ||
| } | ||
| return [] | ||
| } |
There was a problem hiding this comment.
Is template here really used anywhere?
There was a problem hiding this comment.
Good spot, will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-5660
This PR includes a simple use of a suggested templates in zora, as an example.
Implementation deals with situations where:
field.target.template).