Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows Hello IR sensors #107

Open
wants to merge 1 commit into
base: 0.10
Choose a base branch
from
Open

Conversation

jbayardo
Copy link

This PR adds support for reading from the Windows Hello IR sensors by:

  1. Enumerating them in query_activate_pointers.
  2. Adding support for MF_VIDEO_FORMAT_L8

This works on my machine, but I'm unsure if any other formats are used in practice.

I don't really like having added the MF_VIDEO_FORMAT_L8 as a separate FrameFormat (because it's essentially the same as GRAY), but it's also unclear to me how to do this better without rewriting the way in which fulfill works.

@l1npengtul
Copy link
Owner

Hello, 0.10 is considered "dead" - senpai is the current main dev branch. If you could detail how it works, I will add it to 0.11.

0.11 has a much more flexible FrameFormat system, allowing you to have seperate, custom FrameFormats per backend.

@l1npengtul
Copy link
Owner

Sorry for the late response, I got covid and its really taken a toll on my ability to work.

@jbayardo
Copy link
Author

Hey! Oh, no hurry at all! Wish you a speedy recovery :)

I tried using the senpai branch, but it doesn't (or didn't) compile when I was trying to develop against it, so I just used what I knew was working. I'd be happy to backport to it.

The change is simple: it adds a request for sensor cameras. The thing is that the video format wasn't "supported" (it's the same as grayscale).

@l1npengtul
Copy link
Owner

Luma8 will be added in 0.11

@l1npengtul l1npengtul added this to the 0.11 milestone Oct 12, 2024
@l1npengtul l1npengtul added P3 Low Priority (Useful Features) 0.11 Features for 0.11 labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.11 Features for 0.11 P3 Low Priority (Useful Features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants