Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orderBy clause support to aggregate function builder #896

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add orderBy clause support to aggregate function builder #896

wants to merge 18 commits into from

Conversation

ivashog
Copy link

@ivashog ivashog commented Mar 7, 2024 •
edited

@vercel Vercel
Copy link

vercel bot commented Mar 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 0:35am

@ivashog ivashog changed the title feat(operation-node): add order by ro aggregate function node Add order by clause support ro aggregate function builder Mar 7, 2024
@ivashog ivashog changed the title Add order by clause support ro aggregate function builder Add orderBy clause support ro aggregate function builder Mar 7, 2024
@ivashog ivashog marked this pull request as ready for review March 7, 2024 13:25
@ivashog ivashog changed the title Add orderBy clause support ro aggregate function builder Add orderBy clause support to aggregate function builder Mar 7, 2024
@igalklebanov igalklebanov added enhancement New feature or request postgres Related to PostgreSQL api Related to library's API mysql Related to MySQL sqlite Related to sqlite labels Mar 11, 2024
@igalklebanov
Copy link
Member

igalklebanov commented Mar 11, 2024 •
edited

Hey 👋

Thanks! 💪

This is also supported in MySQL and SQLite for some aggregate functions. Let's add tests for those.

@ivashog
Copy link
Author

ivashog commented Mar 12, 2024

Hey

Thanks, @igalklebanov

I follow your recommendation and add a separate test case for order-sensitive aggregate functions including mysql and sqlite.

Also I explore this functionality in mssql and discovered that we need implement within group (order by ...) clause support for aggregate functions - #781. But it is better to implement it in a separate PR, what do you say?

@igalklebanov
Copy link
Member

But it is better to implement it in a separate PR, what do you say?

Yeah, different clause, different PR.

igalklebanov
igalklebanov reviewed Apr 21, 2024
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and functional overall! 💪

Left a few minor suggestions, once addressed this is good to go! 🚀

@ivashog
Copy link
Author

ivashog commented Apr 25, 2024

Looks good and functional overall! 💪

Left a few minor suggestions, once addressed this is good to go! 🚀

@igalklebanov, thanks for review!

igalklebanov
igalklebanov approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL sqlite Related to sqlite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivashog @igalklebanov