[Feature Request] Add tegtBgColor and descColor as api parameter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kyechan99
requested changes
May 14, 2024
Comment on lines
-74
to
+75
| ${textBg === "true" ? Model.textBg(fontColor, fontAlign || 50, fontAlignY || 50, fontSize, text) : ""} | ||
| ${ | ||
| textBg === "true" | ||
| ? checkText(text, textBgColor, fontAlign, fontAlignY, stroke, strokeWidth) | ||
| : checkText(text, fontColor, fontAlign, fontAlignY, stroke, strokeWidth) | ||
| }`; | ||
| ${textBg === "true" ? Model.textBg(textBgColor, fontAlign || 50, fontAlignY || 50, fontSize, text) : ""} | ||
| ${checkText(text, fontColor, fontAlign, fontAlignY, stroke, strokeWidth)}`; |
There was a problem hiding this comment.
위 내용이 변경된 이유를 알 수 있을까요??
기존 결과물과 다르게 작동해요.
기존
https://capsule-render.vercel.app/api?type=rect&color=gradient&text=%20%20RECT%20%20&fontAlign=30&fontSize=30&textBg=true&desc=desc&descAlign=60&descAlignY=50
변경 후
https://capsule-render-theta.vercel.app/api?type=rect&color=gradient&text=%20%20RECT%20%20&fontAlign=30&fontSize=30&textBg=true&desc=desc&descAlign=60&descAlignY=50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! Capsule Render 정말 잘 사용하고 있습니다!
뒤에 색상 없이 딱 이런 버튼 형태의 레이블을 서브헤더로 두고 싶었는데, textBgColor를 fontColor로 text color가 변경이 안되더라구요.
textBgColor를 request parameter로 추가하는게 어떨까요? 그리고 DescColor도 parameter 적용하면 더 다양하게 디자인 할 수 있어서 좋을 것 같습니다!
예시:
감사합니다!