Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson build system support #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

heatd
Copy link

@heatd heatd commented Feb 28, 2023

Can be tested by running meson like:

meson setup build/ # for release builds: --buildtype release
ninja -C build/
ninja -C build/ install # If you don't have perms, ninja tries to gain privileges using polkit. Yay technology

This does not entirely replace the Makefile for some usages, so I did not touch it

@heatd heatd force-pushed the meson branch 3 times, most recently from 6f9c11e to 2382f95 Compare March 1, 2023 01:21
@klange
Copy link
Collaborator

klange commented Mar 1, 2023

We also need rules to generate the codec libraries: https://github.com/kuroko-lang/kuroko/blob/master/Makefile#L129-L133

@klange
Copy link
Collaborator

klange commented Jun 13, 2023

@heatd If you want this in the final release of 1.4, we need to figure out the codec module stuff.

@heatd
Copy link
Author

heatd commented Jun 13, 2023

As noted on IRC, the blocker now is that gen_*.krk scripts do not support input/output arguments, which is obviously a problem given that meson forces you to build out-of-tree

I'm also not compiling every module for the host platform, I'm just compiling libkuroko + kuroko for the native version, since gen_*.krk scripts do not require any "fancy" .so module.

Also! It's worth noting that KUROKOPATH does an oopsie if you give it a non /-terminated path (i.e /usr/lib vs /usr/lib/). As in it tries to do poor path concatenation so you end up with something like "/usr/libjson.krk", which never gets found and the user gets confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants