Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New game : HTML5 Controller Tester #3392

Merged
merged 3 commits into from
May 19, 2024
Merged

Conversation

Ritax2003
Copy link
Contributor

PR Description πŸ“œ

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #3359


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ

1



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

Thank you @Ritax2003 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ritax2003 resolve the conflict !
other things LGTM!

@Ritax2003
Copy link
Contributor Author

I don't understand what the issue is? why it is conflicting. Can you help me pkease?

@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

@Ritax2003 check latest stream there might be some conflicting line at the same line you did modification !

@Ritax2003
Copy link
Contributor Author

Can you please check if the conflict got resolved? i have changed readme file now.

@kunjgit kunjgit merged commit 829d176 into kunjgit:main May 19, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

Thank you @Ritax2003 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

@kunjgit kunjgit added level3 Adding new features gssoc GSSoC24 program label and removed under review labels May 19, 2024
@Ritax2003
Copy link
Contributor Author

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: HTML5 Controller tester
2 participants