Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): add more info in the report #10270

Merged
merged 1 commit into from
May 22, 2024

Conversation

lahabana
Copy link
Contributor

  • Remove TestRuntime as it was just unecessary complexity
  • Add clusterCreationTime to easily figure when a cluster was first created (roughly)
  • Add a zoneHashName to be able to easily uniquely identity the number of zones in a cluster

This should provide better metadata for understand usage

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner May 17, 2024 13:08
@lahabana lahabana requested review from jijiechen, michaelbeaumont and bartsmykla and removed request for a team May 17, 2024 13:08
app/cni/pkg/cni/utils_linux.go Outdated Show resolved Hide resolved
- Remove `TestRuntime` as it was just unecessary complexity
- Add clusterCreationTime to easily figure when a cluster was first
  created (roughly)
- Add a zoneHashName to be able to easily uniquely identity the number
  of zones in a cluster

This should provide better metadata for understand usage

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana enabled auto-merge (squash) May 22, 2024 14:25
@lahabana lahabana merged commit eae22cf into kumahq:master May 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants