Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): meshpassthrough design #10253

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 16, 2024

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested review from a team, jijiechen, michaelbeaumont and bartsmykla and removed request for a team May 16, 2024 19:35
@lukidzi lukidzi added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) ci/skip-e2e-test PR: Don't run e2e tests labels May 16, 2024
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth adding a security consideration section.
Just to state that relying on labels means that it's important to consider that whatever users add there needs to be labels that service owners can't freely set as this would reduce the security posture.

However, someone could just have this reduced security posture and simply rely on auditing.

lukidzi and others added 2 commits May 17, 2024 05:03
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from a team as a code owner May 17, 2024 10:21
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just nits

docs/madr/decisions/050-mesh-passthrough.md Outdated Show resolved Hide resolved
docs/madr/decisions/050-mesh-passthrough.md Outdated Show resolved Hide resolved
docs/madr/decisions/050-mesh-passthrough.md Outdated Show resolved Hide resolved
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@slonka slonka requested a review from lobkovilya May 21, 2024 09:00
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@slonka slonka merged commit a2596a0 into kumahq:master May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants