feat(cli): config:init makes mjs config when using ESModules
#4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnpnl
force-pushed
the
cli-init-mjs-config
branch
from
6b9478e
to
1a71d8f
Compare
ahnpnl
approved these changes
May 28, 2024
Pull Request Test Coverage Report for Build 9263606621Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Installation guide does not work out of the box.
npx ts-jest config:initdoes not respect"type": "module"inpackage.json, causingnpx jestto fail. This PR makesconfig:initsensitive to this case.Test plan
Screencast.from.2023-09-30.12-29-34.webm
Does this PR introduce a breaking change?
Other information
Closes #4012