Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before deleting, check if there are other configurations using the same backend. If there are, do not proceed with the deletion #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wujiuye
Copy link
Contributor

@wujiuye wujiuye commented Aug 18, 2023

…me backend. If there are, do not proceed with the deletion (#374)

@wujiuye wujiuye changed the title Before deleting, check if there are other configurations using the sa… Before deleting, check if there are other configurations using the same backend. If there are, do not proceed with the deletion Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 80.92% and project coverage change: -1.67% ⚠️

Comparison is base (3a96f68) 79.31% compared to head (01f0b82) 77.65%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   79.31%   77.65%   -1.67%     
==========================================
  Files          23       24       +1     
  Lines        1750     2112     +362     
==========================================
+ Hits         1388     1640     +252     
- Misses        278      373      +95     
- Partials       84       99      +15     
Flag Coverage Δ
e2e 0.00% <ø> (∅)
unit 80.39% <80.92%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/terraform/status.go 77.41% <ø> (ø)
e2e/normal/regression.go 0.00% <ø> (ø)
controllers/configuration/configuration.go 89.43% <80.00%> (-5.97%) ⬇️
controllers/configuration_controller.go 79.66% <81.11%> (+2.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…me backend. If there are, do not proceed with the deletion (kubevela#374)

Signed-off-by: 吴就业 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant