Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add information to cli command about vela cluster join without namespace creation #6367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ieuD
Copy link

@ieuD ieuD commented Oct 5, 2023

Description of your changes

🤖 Generated by Copilot at 1f035e8

Summary

🐛📝🚀

Fix unwanted namespace creation in multicluster join. Update flag description for CreateNamespace in cluster.go.

CreateNamespace flag
clarified for multicluster
no more spring cleaning

Walkthrough

  • Clarify the flag description for CreateNamespace in cluster join command (link)

Fixes #
Additional information for vela cluster join command which informs if with empty string in --create-namespace it won't create namespace in target cluster.
I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Eren Cankurtaran added 2 commits October 4, 2023 15:44
Signed-off-by: Eren Cankurtaran <[email protected]>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73c9c75) 65.57% compared to head (1f035e8) 65.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6367      +/-   ##
==========================================
+ Coverage   65.57%   65.58%   +0.01%     
==========================================
  Files         183      183              
  Lines       23885    23885              
==========================================
+ Hits        15662    15665       +3     
+ Misses       6643     6642       -1     
+ Partials     1580     1578       -2     
Flag Coverage Δ
core-unittests 55.38% <ø> (+0.03%) ⬆️
e2e-multicluster-test 31.15% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ieuD ieuD changed the title chore: add additional information for vela cluster join command. chore: add information to cli command about vela cluster join without namespace creation Oct 12, 2023
@ieuD ieuD changed the title chore: add information to cli command about vela cluster join without namespace creation Chore: add information to cli command about vela cluster join without namespace creation Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants