Skip to content

Commit

Permalink
⚡ Template hostPort(s) in the Helm chart
Browse files Browse the repository at this point in the history
  • Loading branch information
mertyildiran committed May 10, 2023
1 parent f68fed0 commit 139336d
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 6 deletions.
40 changes: 40 additions & 0 deletions cmd/helmChart.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,30 @@ func template(object interface{}, mappings map[string]interface{}) (template int
return
}

func handleHubPod(manifest string) string {
lines := strings.Split(manifest, "\n")

for i, line := range lines {
if strings.HasPrefix(strings.TrimSpace(line), "hostPort:") {
lines[i] = " hostPort: {{ .Values.tap.proxy.hub.srvport }}"
}
}

return strings.Join(lines, "\n")
}

func handleFrontPod(manifest string) string {
lines := strings.Split(manifest, "\n")

for i, line := range lines {
if strings.HasPrefix(strings.TrimSpace(line), "hostPort:") {
lines[i] = " hostPort: {{ .Values.tap.proxy.front.srvport }}"
}
}

return strings.Join(lines, "\n")
}

func handlePVCManifest(manifest string) string {
return fmt.Sprintf("{{- if .Values.tap.persistentstorage }}\n%s{{- end }}\n", manifest)
}
Expand All @@ -282,6 +306,14 @@ func handleDaemonSetManifest(manifest string) string {
if strings.TrimSpace(line) == "claimName: kubeshark-persistent-volume-claim" {
lines[i] = fmt.Sprintf("%s\n{{- end }}", line)
}

if strings.HasPrefix(strings.TrimSpace(line), "- containerPort:") {
lines[i] = " - containerPort: {{ .Values.tap.proxy.worker.srvport }}"
}

if strings.HasPrefix(strings.TrimSpace(line), "hostPort:") {
lines[i] = " hostPort: {{ .Values.tap.proxy.worker.srvport }}"
}
}

return strings.Join(lines, "\n")
Expand Down Expand Up @@ -315,6 +347,14 @@ func dumpHelmChart(objects map[string]interface{}) error {
return err
}

if filename == "04-hub-pod.yaml" {
manifest = handleHubPod(manifest)
}

if filename == "06-front-pod.yaml" {
manifest = handleFrontPod(manifest)
}

if filename == "08-persistent-volume-claim.yaml" {
manifest = handlePVCManifest(manifest)
}
Expand Down
2 changes: 1 addition & 1 deletion helm-chart/templates/04-hub-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
name: kubeshark-hub
ports:
- containerPort: 80
hostPort: 8898
hostPort: {{ .Values.tap.proxy.hub.srvport }}
resources:
limits:
cpu: '{{ .Values.tap.resources.hub.limits.cpu }}'
Expand Down
2 changes: 1 addition & 1 deletion helm-chart/templates/06-front-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
name: kubeshark-front
ports:
- containerPort: 80
hostPort: 8899
hostPort: {{ .Values.tap.proxy.front.srvport }}
readinessProbe:
failureThreshold: 3
periodSeconds: 1
Expand Down
4 changes: 2 additions & 2 deletions helm-chart/templates/09-worker-daemon-set.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ spec:
imagePullPolicy: '{{ .Values.tap.docker.imagepullpolicy }}'
name: kubeshark-worker-daemon-set
ports:
- containerPort: 80
hostPort: 8897
- containerPort: {{ .Values.tap.proxy.worker.srvport }}
hostPort: {{ .Values.tap.proxy.worker.srvport }}
resources:
limits:
cpu: '{{ .Values.tap.resources.worker.limits.cpu }}'
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ func (provider *Provider) BuildWorkerDaemonSet(
Image: podImage,
Ports: []core.ContainerPort{{
HostPort: int32(config.Config.Tap.Proxy.Worker.SrvPort),
ContainerPort: configStructs.ContainerPort,
ContainerPort: int32(config.Config.Tap.Proxy.Worker.SrvPort),
}},
ImagePullPolicy: imagePullPolicy,
VolumeMounts: volumeMounts,
Expand Down
2 changes: 1 addition & 1 deletion manifests/09-worker-daemon-set.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
imagePullPolicy: Always
name: kubeshark-worker-daemon-set
ports:
- containerPort: 80
- containerPort: 8897
hostPort: 8897
resources:
limits:
Expand Down

0 comments on commit 139336d

Please sign in to comment.