Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in sidecar-containers.md #49524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkarczmarski
Copy link
Contributor

i deleted the word 'scale' as it seems to be the wrong word .

the section 'Differences from application containers' describes how sidecar containers
work in Pods .

as far as i know there is no 'scaling' mechanism for containers inside a Pod .
so probably:

  • it was supposed to be a different word
  • it might have been added by accident

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit beffce5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67907f1e266fdc000819e959
😎 Deploy Preview https://deploy-preview-49524--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants