Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-br] Sync KubeCon section UI & 2025 links to Portuguese #49442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shurup
Copy link
Member

@shurup shurup commented Jan 15, 2025

Following the recent KubeCon links section UI update & content actualisation for 2025 (#49167), I'm applying the same changes to the Portuguese localisation.

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jcjesus January 15, 2025 05:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign devlware for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fe75e2a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/678a1a4a4971cf0008cd8007
😎 Deploy Preview https://deploy-preview-49442--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shurup
Copy link
Member Author

shurup commented Jan 15, 2025

Oh, as I can see now, the last link (KubeCon NA) doesn't fit due to the longer names for months and cities (in Portuguese). I'm elaborating on possible workarounds to address this…

@shurup
Copy link
Member Author

shurup commented Jan 15, 2025

The issue described above should be fixed by #49443. It'll be good to wait for it being merged first and re-deploy this PR then to see the [better] outcome.

Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, @shurup! Thank you very much for the update in this part!

I left a suggestion to update, since the previous version wasn't quite right from a grammatical standpoint.

Comment on lines 45 to 50
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europe</strong> (Londres, abril 1-4)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, junho 10-11)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japan</strong> (Tóquio, junho 16-17)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>India</strong> (Haiderabade, agosto 6-7)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>North America</strong> (Atlanta, nov. 10-13)</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor bits:

  • In Portuguese, we write the numerical days, followed by a preposition ("de"), then followed by the month name.
  • It seems the countries/continents names were missing translations.
Suggested change
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europe</strong> (Londres, abril 1-4)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, junho 10-11)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japan</strong> (Tóquio, junho 16-17)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>India</strong> (Haiderabade, agosto 6-7)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>North America</strong> (Atlanta, nov. 10-13)</a>
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europa</strong> (Londres, 1-4 de abril)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, 10-11 de junho)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japão</strong> (Tóquio, 16-17 de junho)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>Índia</strong> (Haiderabade, 6-7 de agosto)</a>
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>América do Norte</strong> (Atlanta, 10-13 de novembro)</a>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stormqueen1990 thanks a lot for your help! I applied (and force-pushed) the correct dates. However, I'd like to keep the countries/continents' names intact, since I consider them a part of the official event name. E.g., it's KubeCon + CloudNativeCon Europe (as it's written on the conference website), etc. Thus, it was intentional and the same was done in other localisations (where I propagated this update) 🙏

@stormqueen1990
Copy link
Member

/hold
until #49443 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
Signed-off-by: Dmitry Shurupov <[email protected]>
@shurup shurup force-pushed the pt-kubecon-2025-upgrade branch from f7f274a to fe75e2a Compare January 17, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants