-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt-br] Sync KubeCon section UI & 2025 links to Portuguese #49442
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Oh, as I can see now, the last link (KubeCon NA) doesn't fit due to the longer names for months and cities (in Portuguese). I'm elaborating on possible workarounds to address this… |
The issue described above should be fixed by #49443. It'll be good to wait for it being merged first and re-deploy this PR then to see the [better] outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, @shurup! Thank you very much for the update in this part!
I left a suggestion to update, since the previous version wasn't quite right from a grammatical standpoint.
content/pt-br/_index.html
Outdated
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3> | ||
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europe</strong> (Londres, abril 1-4)</a> | ||
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, junho 10-11)</a> | ||
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japan</strong> (Tóquio, junho 16-17)</a> | ||
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>India</strong> (Haiderabade, agosto 6-7)</a> | ||
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>North America</strong> (Atlanta, nov. 10-13)</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor bits:
- In Portuguese, we write the numerical days, followed by a preposition ("de"), then followed by the month name.
- It seems the countries/continents names were missing translations.
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europe</strong> (Londres, abril 1-4)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, junho 10-11)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japan</strong> (Tóquio, junho 16-17)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>India</strong> (Haiderabade, agosto 6-7)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>North America</strong> (Atlanta, nov. 10-13)</a> | |
<h3>Participe dos próximos eventos KubeCon + CloudNativeCon</h3> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/" class="desktopKCButton"><strong>Europa</strong> (Londres, 1-4 de abril)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-china/" class="desktopKCButton"><strong>China</strong> (Hong Kong, 10-11 de junho)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-japan/" class="desktopKCButton"><strong>Japão</strong> (Tóquio, 16-17 de junho)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-india/" class="desktopKCButton"><strong>Índia</strong> (Haiderabade, 6-7 de agosto)</a> | |
<a href="https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america-2025/" class="desktopKCButton"><strong>América do Norte</strong> (Atlanta, 10-13 de novembro)</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stormqueen1990 thanks a lot for your help! I applied (and force-pushed) the correct dates. However, I'd like to keep the countries/continents' names intact, since I consider them a part of the official event name. E.g., it's KubeCon + CloudNativeCon Europe (as it's written on the conference website), etc. Thus, it was intentional and the same was done in other localisations (where I propagated this update) 🙏
/hold |
Signed-off-by: Dmitry Shurupov <[email protected]>
f7f274a
to
fe75e2a
Compare
Following the recent KubeCon links section UI update & content actualisation for 2025 (#49167), I'm applying the same changes to the Portuguese localisation.