Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] sync service-accounts disruptions kubelet-config-file #46370

Merged
merged 1 commit into from
May 17, 2024
Merged

[zh] sync service-accounts disruptions kubelet-config-file #46370

merged 1 commit into from
May 17, 2024

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented May 14, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 366f513
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6644a78558a564000866f2bd
😎 Deploy Preview https://deploy-preview-46370--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

windsonsea
windsonsea reviewed May 15, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for more natural

content/zh-cn/docs/concepts/security/service-accounts.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/security/service-accounts.md Outdated Show resolved Hide resolved
windsonsea
windsonsea reviewed May 17, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70c3cb5a60f4ee214f37d8d6a848cbbcee2fc340

@tengqm
Copy link
Contributor

tengqm commented May 17, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 422f91b into kubernetes:main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@windsonsea windsonsea windsonsea left review comments

@Sea-n Sea-n Awaiting requested review from Sea-n

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asa3311 @k8s-ci-robot @tengqm @windsonsea