Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sajibAdhi as a reviewer for Bengali localization #46367

Merged
merged 1 commit into from
May 17, 2024

Conversation

asem-hamid
Copy link
Contributor

I am nominating @sajibAdhi as a reviewer for the Kubernetes Bengali localization. He has been an active contributor from the very beginning and has consistently demonstrated a commitment to maintaining high standards of quality in his contributions, making him well-suited for the role of a reviewer.

As one of the SIG-Docs-BN localization maintainers, I'm looking forward to continuing our collaboration with @sajibAdhi.

Requesting a review from other SIG-Docs-BN localization maintainers

@mitul3737
@Imtiaz1234
@rajibmitra

And SIG-Docs localization subproject leads.

@seokho-son
@a-mccarthy

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@asem-hamid asem-hamid changed the title @sajibAdhi has been nominated as a reviewer for Kubernetes Bengali localization sajibAdhi has been nominated as a reviewer for Kubernetes Bengali localization May 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 14, 2024
Copy link

netlify bot commented May 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 71cc94d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66432161a7a0970008d004fa
😎 Deploy Preview https://deploy-preview-46367--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mitul3737 mitul3737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1cfe96f091e4187b0c9cd43245614019879742dd

@sftim
Copy link
Contributor

sftim commented May 14, 2024

/retitle Add sajibAdhi as a reviewer for Bengali localization

@k8s-ci-robot k8s-ci-robot changed the title sajibAdhi has been nominated as a reviewer for Kubernetes Bengali localization Add sajibAdhi as a reviewer for Bengali localization May 14, 2024
@tengqm
Copy link
Contributor

tengqm commented May 17, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Imtiaz1234, mitul3737, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit e64ebe6 into kubernetes:main May 17, 2024
6 checks passed
@asem-hamid asem-hamid deleted the adding-reviewer branch May 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants