Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: include upgrades and cluster-info in external CA workflows #3056

Conversation

neolit123
Copy link
Member

The workflow already includes upgrade artifacts with the same k8s version. Perform upgrade and do cluster-info and kubeadm-e2e before and after the upgrade.

xref #3055

/hold
hold until kubernetes/kubernetes#124682 merges as these changes will fail on 1.29 otherwise.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chendave May 3, 2024 07:45
@k8s-ci-robot k8s-ci-robot added the area/kinder Issues to track work in the kinder tool label May 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu May 3, 2024 07:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2024
@neolit123
Copy link
Member Author

/retest

@neolit123 neolit123 force-pushed the 1.31-kinder-add-upgrade-to-external-ca-e2e branch from 25832b4 to c450067 Compare May 3, 2024 08:59
@neolit123 neolit123 changed the title kinder: include upgrades and cluter-info in external CA workflows kinder: include upgrades and cluster-info in external CA workflows May 3, 2024
The workflow already includes upgrade artifacts with the same
k8s version. Perform upgrade and do cluster-info and kubeadm-e2e
before and after the upgrade.
@neolit123 neolit123 force-pushed the 1.31-kinder-add-upgrade-to-external-ca-e2e branch from c450067 to 4d76a9a Compare May 3, 2024 09:41
@neolit123
Copy link
Member Author

/hold cancel
/cc @pacoxu
/uncc @chendave

@k8s-ci-robot k8s-ci-robot removed the request for review from chendave May 17, 2024 13:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from pacoxu May 17, 2024 13:05
@neolit123
Copy link
Member Author

/hold cancel

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 984c4b8 into kubernetes:main May 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants