Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint README.md #2324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: lint README.md #2324

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 19, 2024

To primarily avoid conflicts and allow for automations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
To primarily avoid conflicts and allow for automations.

Signed-off-by: Pranshu Srivastava <[email protected]>
@mrueg
Copy link
Member

mrueg commented Feb 21, 2024

We already have https://github.com/DavidAnson/markdownlint-cli2 integration, why do we need another markdown formatter/linter?

@rexagod
Copy link
Member Author

rexagod commented Feb 21, 2024

markdownlint-cli2 wasn't able to lint the compatibility matrix, owing to which the padding logic would differ before and after the substitution or insertions were performed there. So running a linter that ensured an overall consistent README.md format would ensure no merge conflicts happen owing to matrix padding.

@dashpole
Copy link

/assign @CatherineF-dev
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2024
@mrueg
Copy link
Member

mrueg commented Feb 23, 2024

markdownlint-cli2 wasn't able to lint the compatibility matrix, owing to which the padding logic would differ before and after the substitution or insertions were performed there. So running a linter that ensured an overall consistent README.md format would ensure no merge conflicts happen owing to matrix padding.

My preference would be a README.md.tpl doc that is authoritative to generate the README.md + a config file, see https://docs.gomplate.ca/usage/ for example.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants