Skip to content

Commit

Permalink
Merge pull request #1977 from CatherineF-dev/clean-up-NewFamilyGenerator
Browse files Browse the repository at this point in the history
Clean up function NewFamilyGenerator in comments
  • Loading branch information
k8s-ci-robot committed Feb 7, 2023
2 parents 86bf8f2 + 4210d50 commit 5ec099b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkg/customresource/registry_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@ type RegistryFactory interface {
//
// func (f *FooFactory) MetricFamilyGenerators(allowAnnotationsList, allowLabelsList []string) []generator.FamilyGenerator {
// return []generator.FamilyGenerator{
// *generator.NewFamilyGenerator(
// *generator.NewFamilyGeneratorWithStability(
// "kube_foo_spec_replicas",
// "Number of desired replicas for a foo.",
// metric.Gauge,
// basemetrics.ALPHA,
// "",
// wrapFooFunc(func(f *samplev1alpha1.Foo) *metric.Family {
// return &metric.Family{
Expand All @@ -67,10 +68,11 @@ type RegistryFactory interface {
// }
// }),
// ),
// *generator.NewFamilyGenerator(
// *generator.NewFamilyGeneratorWithStability(
// "kube_foo_status_replicas_available",
// "The number of available replicas per foo.",
// metric.Gauge,
// basemetrics.ALPHA,
// "",
// wrapFooFunc(func(f *samplev1alpha1.Foo) *metric.Family {
// return &metric.Family{
Expand Down

0 comments on commit 5ec099b

Please sign in to comment.