Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wg-serving: add link to K8s WG Serving playlist #7904

Merged
merged 1 commit into from
May 20, 2024
Merged

wg-serving: add link to K8s WG Serving playlist #7904

merged 1 commit into from
May 20, 2024

Conversation

terrytangyuan
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
ArangoGutierrez
ArangoGutierrez approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@terrytangyuan
Copy link
Member Author

/assign @pacoxu

@SergeyKanzhelev
Copy link
Member

dup of #7862

Reviews are not fast here =)

@terrytangyuan
Copy link
Member Author

Oh oops. I even lgtm-ed that one.

@pacoxu
Copy link
Member

pacoxu commented May 20, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, pacoxu, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2dba3c into kubernetes:master May 20, 2024
3 checks passed
@terrytangyuan terrytangyuan deleted the recording-link branch May 21, 2024 02:59
@terrytangyuan terrytangyuan mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@pacoxu pacoxu

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@terrytangyuan @SergeyKanzhelev @pacoxu @k8s-ci-robot @ArangoGutierrez